Parquet: Cache adjacent identical metadata in variant reader#16852
Open
nssalian wants to merge 3 commits into
Open
Parquet: Cache adjacent identical metadata in variant reader#16852nssalian wants to merge 3 commits into
nssalian wants to merge 3 commits into
Conversation
wombatu-kun
reviewed
Jun 18, 2026
wombatu-kun
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VariantMetadataReadernow caches the last parsedVariantMetadataso adjacent rows with identical metadata bytes skip the re-parse.Test plan
testMetadataCacheHits: 50 rows of identical metadata; reference identity proves the cached instance is reused.testMetadataCacheInvalidatesByLength: alternating metadata of different lengths; the length pre-check forces invalidation.testMetadataCacheInvalidatesByBytes: pairs of identical-length-different-bytes metadata;bufferEqualsmust discriminate by content.